The following warnings occurred:
Warning [2] Undefined property: MyLanguage::$archive_pages - Line: 2 - File: printthread.php(287) : eval()'d code PHP 8.3.31 (Linux)
File Line Function
/inc/class_error.php 153 errorHandler->error
/printthread.php(287) : eval()'d code 2 errorHandler->error_callback
/printthread.php 287 eval
/printthread.php 117 printthread_multipage



MyBB Group
Link Tools - Printable Version

+- MyBB Group (https://mybb.group)
+-- Forum: MyBB Extends (https://mybb.group/Forum-MyBB-Extends)
+--- Forum: Originated (https://mybb.group/Forum-Originated)
+--- Thread: Link Tools (/Thread-Link-Tools)

Pages: 1 2 3


RE: Link Tools - Laird - 24-09-2024

(24-09-2024, 09:49 AM)antoineboy57 Wrote: Perfect !

Thank you for your kind answer.
The actions in the administration panel are working until the end
  • All 742 links have been successfully extracted from all 1,234 posts.
  • 26 of 742 links have not been resolved into their terminating links. Attempts have been unsuccessfully made for all 26 of them. None of these links is eligible for another resolution attempt right now: reattempts of failed resolutions are subject to staggered delays as there is typically no point in retrying immediately; instead, the need is to wait for any network/server problem(s) to be fixed.
My forums are not crashing anymore for https://www.cae-eco.fr/

X.com links are working.

Great, thanks for the feedback.

(24-09-2024, 09:49 AM)antoineboy57 Wrote: Problems not solved :

Can you please be more specific about what the problem is exactly?

(24-09-2024, 09:49 AM)antoineboy57 Wrote:
  • if i am trying to put a link-previewers-3rd-party it is also crashing (i have tried to put the old LinkPreviewerTwitterStatus.php but maybe i don't know the way to write link previewer correctly)

Did you rename the class? You can't have two classes with the same name.

(24-09-2024, 09:49 AM)antoineboy57 Wrote: For future requests, would you prefer to exchange here or in the github?

Here seems to be working, but GitHub is fine too.


RE: Link Tools - antoineboy57 - 25-09-2024

(24-09-2024, 02:00 PM)Laird Wrote:  
(24-09-2024, 09:49 AM)antoineboy57 Wrote: Problems not solved :

Can you please be more specific about what the problem is exactly?

when I try to send a pdf link, it ends with a blank page on

.../newthread.php?fid=nb&processed=1

BUT apparently topics and replies are well created
(need to reload the forum url)
 
(24-09-2024, 02:00 PM)Laird Wrote:  
(24-09-2024, 09:49 AM)antoineboy57 Wrote:
  • if i am trying to put a link-previewers-3rd-party it is also crashing (i have tried to put the old LinkPreviewerTwitterStatus.php but maybe i don't know the way to write link previewer correctly)

Did you rename the class? You can't have two classes with the same name.

Ok it is working
with the class LinkPreviewerXStatus


RE: Link Tools - antoineboy57 - 27-09-2024

Humm apparently now when posting links
newreply.php?tid=461&processed=1
blank page
Need to combe back to the forum to see the forum updated.


RE: Link Tools - Laird - 27-09-2024

(25-09-2024, 01:32 PM)antoineboy57 Wrote: when I try to send a pdf link, it ends with a blank page on

.../newthread.php?fid=nb&processed=1

BUT apparently topics and replies are well created
(need to reload the forum url)

Probably, your connection to the web server is timing out as the server tries to download the PDF: currently, all links in a post are downloaded right then and there when the post is submitted.

It might be worth my adding a setting to allow deferring those downloads to the regular Link Tools task that runs.
(25-09-2024, 01:32 PM)antoineboy57 Wrote: Ok it is working
with the class LinkPreviewerXStatus

Good to know.

Just to be clear: with the fixes I linked to in my last post, you shouldn't need any custom previewers for x.com (and the original twitter.com) links to work, so let me know if you do, because that's a bug.


RE: Link Tools - antoineboy57 - 27-09-2024

Quote:Probably, your connection to the web server is timing out as the server tries to download the PDF: currently, all links in a post are downloaded right then and there when the post is submitted.

Strange, it's happening everytime, with firefox blank page, with Brave it's written "
[align=start]Error[/align]
HTTP ERROR 500". But on my smartphone with Iceweasel no problem .


RE: Link Tools - antoineboy57 - 08-10-2024

after a time of adaptation, i think now the plugin is working properly (no HTTP ERROR 500)


RE: Link Tools - antoineboy57 - 18-10-2024

No there is still an issue apparently when you are posting only a link. blank page.


RE: Link Tools - Laird - 18-10-2024

(18-10-2024, 08:38 AM)antoineboy57 Wrote: No there is still an issue apparently when you are posting only a link. blank page.

I can't reproduce this. Can you please provide a recipe to reproduce it?


RE: Link Tools - antoineboy57 - 05-06-2025

Thanks to ChatGPT, I discovered why I was getting a 500 error!
The issue is in
linktools.php
, line 3393:
 
lkt_store_urls($g_lkt_links_incl_vids, $g_lkt_redirs, $g_lkt_got_terms, $posthandler->pid);

I have commented out this line. Everything works fine now, but I am wondering: is the storage function actually necessary for the plugin to work correctly?


---------Bug Report: Fatal Error when calling
[b]lkt_store_urls()[/b]
due to missing
[b]spam_class[/b]
columnSummary:
When submitting a post containing a link, the plugin attempts to call the function
 
lkt_store_urls($g_lkt_links_incl_vids, $g_lkt_redirs, $g_lkt_got_terms, $posthandler->pid);

which leads to a fatal error because the SQL query refers to a
spam_class
column that does not exist in the database.Error message:
Fatal error: Uncaught mysqli_sql_exception: Unknown column 'spam_class' in 'INSERT INTO' in mybbforum/inc/db_mysqli.php:335
Stack trace:
#0 mybbforum/inc/db_mysqli.php(335): mysqli_query()
#1 mybbforum/inc/db_mysqli.php(378): DB_MySQLi->query()
#2 mybbforum/inc/plugins/linktools.php(1939): DB_MySQLi->write_query()
#3 mybbforum/inc/plugins/linktools.php(3396): lkt_store_urls()
#4 mybbforum/inc/class_plugins.php(142): lkt_hookin__datahandler_post_update_or_merge_end()
#5 mybbforum/inc/datahandlers/post.php(2032): pluginSystem->run_hooks()
#6 mybbforum/editpost.php(565): PostDataHandler->update_post()
#7 {main} thrown in mybbforum/inc/db_mysqli.php on line 335



RE: Link Tools - Laird - 05-06-2025

That column should be added on upgrade. Maybe you forgot that the upgrade procedure requires that you deactivate the plugin before copying the new files and then activate it again afterwards. Try deactivating then reactivating it now.