Released version 1.4.1 with the following additions:

• Bugfix: the forums of link limit rules weren't being respected; limits were being applied to all forums regardless of those selected.
  
• Enhancement: improved the respecting of link limits when editing posts.
  

Hi Laird!
I'm having this issue with the plugin:



The plugin page at CP Admin is like this:



Is it something I did wrong?

Ps.: My forum has not https enabled, does it have something do to with it?

Hi Laird!
I'm having this issue with the plugin:



The plugin page at CP Admin is like this:



Is it something I did wrong?

Ps.: My forum has not https enabled, does it have something do to with it?

A belated response, and probably due to its lateness, neither of those images are now accessible. If you're still having a problem, especially after upgrading to the new release (next post), then please let us know.

Released version 1.5.0 with the following additions:

• New major features:
  
  • Two new per-usergroup and per-forum settings to have posts moderated when a link is (1) edited in or (2) present on initial posting. These are accessible from the usual places in the ACP for settings of this type, rather than from the plugin's settings.
    
  • Anti-link spam features, namely:
    
    • New plugin settings to stipulate actions to take (purge spammer, reject post, or moderate post; how to classify other links in the member's post(s)) when a link classified as spam is posted or edited into a post and other criteria are met (usergroup, post count, account age).
      
    • A link listing via which the spam classification of links can be set (as "Unclassified", "Potential spam", "Not spam", or "Spam"). Links can also be filtered by both spam classification and partial match.
      
    • Support via the link listing for importing multiple links and bulk classifying them, with the expectation that "Spam" will be the commonest import classification.
      
    • Support via a checkbox when purging a spammer manually, and when deleting threads/posts in the moderation queue, for auto-classifying links in the spammer's post(s) as spam.
      
    • A new creation date associated with links so as to sort the link listing by most recent links.
      
    • An auto-population of the creation date for preexisting links based on the earliest post in which they occur where they do occur in any post, accessible via the plugin's entry on the ACP's plugin page: if any links meeting this criteria exist, a message and link are provided to run the auto-population; otherwise, no message and link are provided and the plugin's silence indicates that creation dates have been set for all links for which it is possible.
      
    • A red header messages is shown to admins when any "Potential spam" links exist, which links to the link listing via which these links can be definitively classified as "Spam" or "Not spam". This is intended for the scenario in which according to the plugin's settings links are auto-classified as "Potential spam" when taking action based on those same settings.
      
• New minor features:
  
  • Adds missing support for link searches in in-thread searches.
    
  • Admin logging added: for when updating link previewers and when updating link limits.
    
• Greatly improved PHP 8 support: many fixes for uninitialised variables and missing array entries.
  
• Improved handling of settings, especially removing settings on uninstall.
  
• Improved cURL testing script: it now checks for the presence of all relevant cURL functions rather than just one.
  
• Minor templating improvement: moved the <br /> prior to $disablelinkpreviews into the linktools_cbxdisablelinkpreview template itself.
  
• Minor language file improvement: moved the constant out of it.
  
• Various minor improvements and fixes.
  

Hello,

Two problems with the new version :

• cannot see the twitter preview anymore (change to x.com ?)
  
• this website https://www.cae-eco.fr/ made my forum crash. I cannot use the plugin....
  

Apparently the plugin has issues with link terminate by .pdf
I disable the Plain text previewer to avoid my forum crashing on some subject.

Also now the twitter preview is outdated (url become X.com the link preview showed a mention to an outdated browser)

try to comeback to 4.1

When using
 (...) /admin/index.php?module=tools-recount_rebuild
for the first timeSuccessfully repopulated the links tables for Link Tools.

But when I do the action "to resolve have not been resolved into their terminating links"
 (...)  /admin/index.php?module=tools-recount_rebuild
become a blank page.

And the links are not corrected.

It might be interesting to compile a list of all uncorrected links, so that we can understand which links are causing problems.

Thanks for these reports and your PM alerting me to them. I hadn't checked in to this board since releasing the latest version of Link Tools, and for some reason hadn't been alerted to any of them despite being subscribed to this thread. I've approved the two that had been subjected to moderation.

cannot see the twitter preview anymore (change to x.com ?)

Confirmed. I'm working on this.

this website https://www.cae-eco.fr/ made my forum crash.

Confirmed again. I have fixed this in local development code.

The issue was that that site reports a character set not supported by PHP's mb_convert_encoding() function, which was not problematic for PHP < 8 because in that case only a warning was generated, which Link Tools was successfully suppressing. PHP 8 instead throws an exception, which Link Tools wasn't handling.

I've fixed this by calling functions to generate a list of supported character sets and checking that the argument to be supplied to mb_convert_encoding() actually exists in that list before supplying it.

Apparently the plugin has issues with link terminate by .pdf
I disable the Plain text previewer to avoid my forum crashing on some subject.

PDFs are fine so long as they are served with an appropriate content type, in which case Link Tools ignores them.

It seems that the PDF you're linking to is being served with the inappropriate "text/plain" content type. I haven't tested that scenario. Can you please provide an example link?

When using
 (...) /admin/index.php?module=tools-recount_rebuild
for the first timeSuccessfully repopulated the links tables for Link Tools.

But when I do the action "to resolve have not been resolved into their terminating links"
 (...)  /admin/index.php?module=tools-recount_rebuild
become a blank page.

I am yet to investigate this. I'll let you know how I go. It might have been caused by the now-resolved problem with https://www.cae-eco.fr/, in which case it might need no further fix.

It might be interesting to compile a list of all uncorrected links, so that we can understand which links are causing problems.

Yes, that might be useful. I'll consider it.

I've pushed a bunch of commits which hopefully fix all bugs. Please download the current version from our GitHub repository and let me know how you go. There's no need to run any upgrade procedure so you should be able to just copy across the updated files. After that, set its ACP plugin setting "Scope of Rebuild Link Previews entry" to "All" and then run all Link Tools-related rebuild tools.

Some more specific comments:

cannot see the twitter preview anymore (change to x.com ?)

Confirmed. I'm working on this.

Fixed. This required the implementation of site-specific cookies.

this website https://www.cae-eco.fr/ made my forum crash.

Confirmed again. I have fixed this in local development code.

Here is the fix.

Apparently the plugin has issues with link terminate by .pdf
I disable the Plain text previewer to avoid my forum crashing on some subject.

PDFs are fine so long as they are served with an appropriate content type, in which case Link Tools ignores them.

It seems that the PDF you're linking to is being served with the inappropriate "text/plain" content type. I haven't tested that scenario. Can you please provide an example link?

After further testing, I found that as you affirmed, sometimes Link Tools was mistakenly applying the plain text previewer to PDFs. I am not 100% sure I've fixed this, so please let me know how you go with the new code.

When using
 (...) /admin/index.php?module=tools-recount_rebuild
for the first timeSuccessfully repopulated the links tables for Link Tools.

But when I do the action "to resolve have not been resolved into their terminating links"
 (...)  /admin/index.php?module=tools-recount_rebuild
become a blank page.

I am yet to investigate this. I'll let you know how I go. It might have been caused by the now-resolved problem with https://www.cae-eco.fr/, in which case it might need no further fix.

I haven't been able to identify any further problem, so for now I assume that it was caused by that now-resolved problem. Again, please let me know how you go with the new code.

It might be interesting to compile a list of all uncorrected links, so that we can understand which links are causing problems.

Yes, that might be useful. I'll consider it.

I haven't implemented this (yet?).

Perfect !

Thank you for your kind answer.
The actions in the administration panel are working until the end

• All 742 links have been successfully extracted from all 1,234 posts.
  
• 26 of 742 links have not been resolved into their terminating links. Attempts have been unsuccessfully made for all 26 of them. None of these links is eligible for another resolution attempt right now: reattempts of failed resolutions are subject to staggered delays as there is typically no point in retrying immediately; instead, the need is to wait for any network/server problem(s) to be fixed.
  

My forums are not crashing anymore for https://www.cae-eco.fr/

X.com links are working.

Problems not solved :

• for the pdf. Direct link to big pdf are not working ex (42 mo) https://www.diplomatie.gouv.fr/IMG/pdf/r...0d9435.pdf
  
• if i am trying to put a link-previewers-3rd-party it is also crashing (i have tried to put the old LinkPreviewerTwitterStatus.php but maybe i don't know the way to write link previewer correctly)
  

For future requests, would you prefer to exchange here or in the github?